-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Button): enable loading state for button #253
Conversation
|
||
{loading ? ( | ||
{loading && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 can't believe that this was the issue 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't we we missing the loader colors and the transparencies to the text too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that the colors were missing but what about the size of the button? It is not affected by the colors right?
Added a missing fix on the follow button here 1929b17 result: Simulator.Screen.Recording.-.iPhone.14.-.2024-09-16.at.17.26.58.mp4 |
🚀 PR was released in |
This reverts commit 8f6a59c.
Description
Fixes loading states similar to what was done in #243.
Co-authored by @gkartalis
Simulator.Screen.Recording.-.iPhone.14.-.2024-09-16.at.16.56.41.mp4