Resolve a few straightforward mypy type errors. (#1492)

* Add missing type hint to resolve mypy type inference failure. * Suppress conditional ujson/json import-related mypy errors.
arviz-devs · Jan 10, 2021 · 910e781 · 910e781
1 parent 4208df8
commit 910e781
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/arviz/data/base.py b/arviz/data/base.py
@@ -12,7 +12,9 @@
 try:
     import ujson as json
 except ImportError:
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 from .. import __version__, utils
 

diff --git a/arviz/data/inference_data.py b/arviz/data/inference_data.py
@@ -20,7 +20,9 @@
 try:
     import ujson as json
 except ImportError:
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 SUPPORTED_GROUPS = [
     "posterior",

diff --git a/arviz/data/io_json.py b/arviz/data/io_json.py
@@ -6,7 +6,9 @@
     import ujson as json
 except ImportError:
     # Can't find ujson using json
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 
 def from_json(filename):

diff --git a/arviz/data/io_pystan.py b/arviz/data/io_pystan.py
@@ -17,7 +17,9 @@
     import ujson as json
 except ImportError:
     # Can't find ujson using json
-    import json
+    # mypy struggles with conditional imports expressed as catching ImportError:
+    # https://github.com/python/mypy/issues/1153
+    import json  # type: ignore
 
 
 class PyStanConverter:

diff --git a/arviz/tests/helpers.py b/arviz/tests/helpers.py
@@ -241,7 +241,7 @@ def check_multiple_attrs(
     in ``sample_stats``, also against what was expected.
 
     """
-    failed_attrs = []
+    failed_attrs: List[Union[str, Tuple[str, str]]] = []
     for dataset_name, attributes in test_dict.items():
         if dataset_name.startswith("~"):
             if hasattr(parent, dataset_name[1:]):