Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross validation defaults: loo and log -scale #1067

Merged
merged 7 commits into from
Feb 13, 2020

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Feb 13, 2020

Description

Use loo as a default cross validation method.
Use log -scale as a default cross validation scale.

This is to make our results compatible with R ecosystem (loo) by default.

Checklist

  • Does the PR follow official
    PR format?
  • Is the new feature properly documented with an example?
  • Does the PR include new or updated tests to cover the new feature (using pytest fixture pattern)?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the change listed in changelog?

arviz/plots/compareplot.py Outdated Show resolved Hide resolved
arviz/plots/elpdplot.py Outdated Show resolved Hide resolved
@ahartikainen ahartikainen merged commit 63ba54f into master Feb 13, 2020
@ahartikainen ahartikainen deleted the update_default_ic branch February 13, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants