Add support for discrete variables in rank plots #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a similar trick to the one used in
plot_bpv
for discrete variables.Good sample
OLD
NEW
Bad sample (excess of 2s in one chain)
OLD
NEW
Bad sample (two different distributions)
OLD
NEW
As you can see with the old version discrete samples always look bad (and more or less the same). With the new version not only they look good when they should, they actually reflect the nature of problem with the sampling went wrong.