Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove geweke diagnostic #1545

Merged
merged 2 commits into from
Feb 8, 2021
Merged

remove geweke diagnostic #1545

merged 2 commits into from
Feb 8, 2021

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Feb 8, 2021

This removes geweke diagnostic as we have better diagnostic tools. I did not added a deprecation warning because geweke have been broken for a while and we have not heard any complaints, so probably nobody is using it anyways.

  • Follows official PR format
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #1545 (8fbfa6d) into main (2dff682) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
- Coverage   91.09%   91.07%   -0.02%     
==========================================
  Files         105      105              
  Lines       11384    11361      -23     
==========================================
- Hits        10370    10347      -23     
  Misses       1014     1014              
Impacted Files Coverage Δ
arviz/stats/__init__.py 100.00% <ø> (ø)
arviz/stats/diagnostics.py 99.21% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dff682...4d40547. Read the comment docs.

@canyon289 canyon289 merged commit 6fa1ce8 into main Feb 8, 2021
@aloctavodia
Copy link
Contributor Author

poor geweke, not even a little bit of resistant :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants