-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some extra rcparams #1611
add some extra rcparams #1611
Conversation
Logic is now wrong. I have a model with a variable from_xyz(log_likelihood="log_lik2") --> log_lik goes to log_likelihood. |
True, it only has to be triggered if log_likelihood is exactly true, not if it evaluates to true, I always mess this up |
eb25348
to
686dad7
Compare
|
Yeah, when there is true (?) and no log_lik, it will of course fail, so we need to put it back to None. |
I was thinking that it may be easier to set |
nevermind, it's basically the same, it would be something like: self.log_likelihood = None
log_likelihood = rcParams if ... # instead of doing that on self.log_likelihood
# [...]
# keep the same conditions but using log_likelihood instead of self.log_likelihood
# skip the if isinstance(..., bool) which is not any improvement. Let's merge like this |
* add some extra rcparams * black+changelog * fix imports * fix logic * fix tests * Fix log_likelihood behaviour * add more tests * fix typo * fix lint * black * mypy fix * add plot.density_type * black * update changelog * update mypy.ini * fix tests * update empty test * fix logic again Co-authored-by: Ari Hartikainen <[email protected]> Co-authored-by: Ari Hartikainen <[email protected]> Co-authored-by: Ari Hartikainen <[email protected]>
Description
Adds two new rcParams, data.log_likelihood and stats.ic_compare_method. Also fixes a couple of
mishaps in index_origin usage.
Checklist
PR format?
section of the changelog?