-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify compare() docstring, error-check, pass var_name. #1616
Commits on Mar 26, 2021
-
Modify compare() docstring, and var_name param and error-check.
Check to see if the log_likelihood groups have more than one data variable, and if so, require the var_name parameter. This avoids having a less understandable error message crop up later. Introduce `var_name` parameter, and pass it through to the IC function invoked by compare.
Configuration menu - View commit details
-
Copy full SHA for 0791283 - Browse repository at this point
Copy the full SHA 0791283View commit details -
Configuration menu - View commit details
-
Copy full SHA for be8c21d - Browse repository at this point
Copy the full SHA be8c21dView commit details -
Previously, if we got a TypeError when trying to find a log_likelihood in from_pymc3() that TypeError would be squashed completely. Now we will echo it to the log before handling it.
Configuration menu - View commit details
-
Copy full SHA for ce480fd - Browse repository at this point
Copy the full SHA ce480fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c4d06 - Browse repository at this point
Copy the full SHA 63c4d06View commit details -
Annotated IC function errors from compare().
Catch errors from IC functions invoked inside compare and annotate them with information about the source `InferenceData` object.
Configuration menu - View commit details
-
Copy full SHA for 37c2e81 - Browse repository at this point
Copy the full SHA 37c2e81View commit details -
Configuration menu - View commit details
-
Copy full SHA for b50b6de - Browse repository at this point
Copy the full SHA b50b6deView commit details -
Configuration menu - View commit details
-
Copy full SHA for e850385 - Browse repository at this point
Copy the full SHA e850385View commit details -
Configuration menu - View commit details
-
Copy full SHA for c367270 - Browse repository at this point
Copy the full SHA c367270View commit details
Commits on Mar 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 50ee13c - Browse repository at this point
Copy the full SHA 50ee13cView commit details -
Make "e" acceptable variable name.
Many examples show this as a good variable name for exceptions, particularly in "except <ExceptionClass> as e:"
Configuration menu - View commit details
-
Copy full SHA for cf2e8b5 - Browse repository at this point
Copy the full SHA cf2e8b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b0ad6e - Browse repository at this point
Copy the full SHA 7b0ad6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31be080 - Browse repository at this point
Copy the full SHA 31be080View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6edc71e - Browse repository at this point
Copy the full SHA 6edc71eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb162c - Browse repository at this point
Copy the full SHA 7eb162cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d27fd5 - Browse repository at this point
Copy the full SHA 6d27fd5View commit details
Commits on Mar 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9e61c58 - Browse repository at this point
Copy the full SHA 9e61c58View commit details
Commits on Mar 29, 2021
-
Make sure we check for multiple observed variables in compare() and that support for "var_name" works.
Configuration menu - View commit details
-
Copy full SHA for 1a31db2 - Browse repository at this point
Copy the full SHA 1a31db2View commit details -
Don't let sample_stats shadow log_likelihood.
Previously, we checked for `sample_stats` in `get_log_likelihood()` *before* reading `log_likelihood`. Add a check that `log_likelihood` must be missing before we check `sample_stats`.
Configuration menu - View commit details
-
Copy full SHA for a6d14ef - Browse repository at this point
Copy the full SHA a6d14efView commit details -
Improvements suggested by OriolAbril.
* Limit recomputation in tests by scoping a fixture. * Test for expected IC in `compare` test. * Refine type assertion.
Configuration menu - View commit details
-
Copy full SHA for 29a03ea - Browse repository at this point
Copy the full SHA 29a03eaView commit details