Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify compare() docstring, error-check, pass var_name. #1616

Merged
merged 19 commits into from
Mar 30, 2021

Commits on Mar 26, 2021

  1. Modify compare() docstring, and var_name param and error-check.

    Check to see if the log_likelihood groups have more than one data variable, and if so, require the var_name parameter. This avoids having a less understandable error message crop up later.
    Introduce `var_name` parameter, and pass it through to the IC function invoked by compare.
    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    0791283 View commit details
    Browse the repository at this point in the history
  2. Fix error in argument test.

    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    be8c21d View commit details
    Browse the repository at this point in the history
  3. More explicit error message.

    Previously, if we got a TypeError when trying to find a log_likelihood
    in from_pymc3() that TypeError would be squashed completely. Now we
    will echo it to the log before handling it.
    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ce480fd View commit details
    Browse the repository at this point in the history
  4. Fix type signature of compare().

    Took @OriolAbril correction.
    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    63c4d06 View commit details
    Browse the repository at this point in the history
  5. Annotated IC function errors from compare().

    Catch errors from IC functions invoked inside compare and annotate
    them with information about the source `InferenceData` object.
    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    37c2e81 View commit details
    Browse the repository at this point in the history
  6. Remove incorrect docstring.

    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b50b6de View commit details
    Browse the repository at this point in the history
  7. pylint

    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e850385 View commit details
    Browse the repository at this point in the history
  8. mypy fixes.

    rpgoldman committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    c367270 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Configuration menu
    Copy the full SHA
    50ee13c View commit details
    Browse the repository at this point in the history
  2. Make "e" acceptable variable name.

    Many examples show this as a good variable name for exceptions,
    particularly in "except <ExceptionClass> as e:"
    rpgoldman committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    cf2e8b5 View commit details
    Browse the repository at this point in the history
  3. Changelog update.

    rpgoldman committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    7b0ad6e View commit details
    Browse the repository at this point in the history
  4. Backward-compatibility fix.

    rpgoldman committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    31be080 View commit details
    Browse the repository at this point in the history
  5. Fix test.

    Error now caught sooner.
    rpgoldman committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    6edc71e View commit details
    Browse the repository at this point in the history
  6. Fix mypy issues.

    rpgoldman committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    7eb162c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6d27fd5 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Configuration menu
    Copy the full SHA
    9e61c58 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Test for error-trapping.

    Make sure we check for multiple observed variables in compare() and that support for "var_name" works.
    rpgoldman committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    1a31db2 View commit details
    Browse the repository at this point in the history
  2. Don't let sample_stats shadow log_likelihood.

    Previously, we checked for `sample_stats` in `get_log_likelihood()` *before* reading `log_likelihood`.  Add a check that `log_likelihood` must be missing before we check `sample_stats`.
    rpgoldman committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    a6d14ef View commit details
    Browse the repository at this point in the history
  3. Improvements suggested by OriolAbril.

    * Limit recomputation in tests by scoping a fixture.
    * Test for expected IC in `compare` test.
    * Refine type assertion.
    rpgoldman committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    29a03ea View commit details
    Browse the repository at this point in the history