Use only is_circular argument in plot_dist
#1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -522,6 +522,8 @@ def kde(x, circular=False, **kwargs): | |||
| arviz.stats.density_utils.kde: Arviz KDE estimator | |||
| """ | |||
| if circular: | |||
| if circular == "degrees": | |||
There was a problem hiding this comment.
Given that _kde_circular assumes inputs are in radians I added this internal conversion. We can discuss where else we can place it or if it should exist at all.
OriolAbril
approved these changes
Apr 29, 2021
agustinaarroyuelo
changed the title
is_circular argument in plot_distis_circular argument in plot_dist
utkarsh-maheshwari
pushed a commit
to utkarsh-maheshwari/arviz
that referenced
this pull request
May 27, 2021
* use only is_circular argument * change xlabels * update posteriorplot and traceplot * update bokeh plots * add internal conversion for inputs in degrees * update changelog and docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
circularwas used to indicate"taylor"bandwidht for thekdefunction and it co existed with theis_circularargument. In this PR I removedcircularin favor ofis_circular.Checklist