Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly (re)order dimensions for bfmi and plot_energy #2126

Merged
merged 8 commits into from
Oct 2, 2022
Merged

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Oct 1, 2022

Description

This PR ensures that bfmi and plot_energy compute the same thing if the named dimensions (chain, draw) are instead ordered as (draw, chain) and adds a test.

Addresses part of #2102 (comment)

Checklist

  • Does the PR follow official
    PR format?
  • Does the PR include new or updated tests to prevent issue recurrence (using pytest fixture pattern)?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes
    section of the changelog?

📚 Documentation preview 📚: https://arviz--2126.org.readthedocs.build/en/2126/

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #2126 (45764ca) into main (3c2dc6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files         117      117           
  Lines       12501    12501           
=======================================
+ Hits        11347    11348    +1     
+ Misses       1154     1153    -1     
Impacted Files Coverage Δ
arviz/plots/energyplot.py 88.88% <100.00%> (+5.55%) ⬆️
arviz/stats/diagnostics.py 98.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sethaxen sethaxen changed the title Correctly (re)order dimensions for bfmi Correctly (re)order dimensions for bfmi and plot_energy Oct 1, 2022
@sethaxen sethaxen merged commit bc1e887 into main Oct 2, 2022
@sethaxen sethaxen deleted the addordertests branch October 2, 2022 06:37
@sethaxen sethaxen mentioned this pull request Oct 2, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants