Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dimension ordering for traceplot with divergences #2151

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Nov 1, 2022

Description

Fixes #2150 by internally reordering dimensions of diverging as expected in plot_trace.

Checklist

  • Does the PR follow official
    PR format?
  • Does the PR include new or updated tests to prevent issue recurrence (using pytest fixture pattern)?
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the fix listed in the Maintenance and fixes
    section of the changelog?

📚 Documentation preview 📚: https://arviz--2151.org.readthedocs.build/en/2151/

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #2151 (8e7c4b5) into main (d030d44) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2151   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         118      118           
  Lines       12579    12579           
=======================================
  Hits        11413    11413           
  Misses       1166     1166           
Impacted Files Coverage Δ
arviz/plots/traceplot.py 95.34% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sethaxen sethaxen merged commit d9b75bb into main Nov 1, 2022
@sethaxen sethaxen deleted the fixtraceplotdiverg branch November 1, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_trace assumes specific dimensions ordering for divergences
2 participants