Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default nopython kwarg #2246

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Add default nopython kwarg #2246

merged 3 commits into from
Jun 10, 2023

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented May 24, 2023

Description

Fix deprecation warning with numba jit.

Checklist

  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2246.org.readthedocs.build/en/2246/

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #2246 (1a1c328) into main (61bda88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files         120      120           
  Lines       12417    12425    +8     
=======================================
+ Hits        10915    10923    +8     
  Misses       1502     1502           
Impacted Files Coverage Δ
arviz/utils.py 88.27% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@OriolAbril OriolAbril merged commit 8a1b37e into main Jun 10, 2023
@OriolAbril OriolAbril deleted the bugfix/numba_default_nopython branch June 10, 2023 08:54
@OriolAbril
Copy link
Member

Didn't really fix the warning, only changed it now that I try it locally:

/home/oriolabrilpla/mambaforge/envs/arviz/lib/python3.10/site-packages/arviz/utils.py:185: NumbaDeprecationWarning: The keyword argument 'nopython=False' was supplied. From Numba 0.59.0 the default is being changed to True and use of 'nopython=False' will raise a warning as the argument will have no effect. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.
  numba_fn = numba.jit(**self.kwargs)(self.function)

@ahartikainen
Copy link
Contributor Author

haha, great

What is the correct solution?

@OriolAbril
Copy link
Member

still don't know, will look into it next week 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants