Set matplotlib >=3.5 in requirements.txt #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since arviz-devs#2127 `arviz/__init__.py` requires matplotlib >= 3.5 for `mpl.colormaps.register()` otherwise `arviz` fails on import.
Codecov Report
@@ Coverage Diff @@
## main #2280 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 122 122
Lines 12459 12459
=======================================
Hits 10811 10811
Misses 1648 1648 |
OriolAbril
reviewed
Sep 29, 2023
There was a problem hiding this comment.
Thanks! I have also added a suggestion to update the numpy cap and the pandas one should also be updated so that we can roughly follow https://scientific-python.org/specs/spec-0000/. Do you mind doing that?
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| setuptools>=60.0.0 | |||
| matplotlib>=3.2 | |||
| matplotlib>=3.5 | |||
| numpy>=1.21.0,<2.0 | |||
There was a problem hiding this comment.
Suggested change
| numpy>=1.21.0,<2.0 | |
| numpy>=1.22.0,<2.0 |
OriolAbril
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Fix deprecation of matplotlib.pyplot.register_cmap #2127
arviz/__init__.pyrequires matplotlib >= 3.5 formpl.colormaps.register()otherwisearvizfails on import.Checklist