[WIP] Changed the stats scale as default to None and made changes accordingly as suggested as per the issue #985

[Shashankjain12]

fixes #985

[OriolAbril]

Hi @Shashankjain12 If you enter to the build logs you will see that only one of the 5 jobs is failing, the one called lint. This is due to the code formatting not following the black code style, this should be solved by black arviz/ examples/ (it's the 3rd point starting from the end in the pull request checklist).

As to solving the issue, you have now solved the issue only partially. compare will now use the value in rcParams, however, there are still functions like loo, waic and elpd_plot that do not yet use the value in rcParams.

[OriolAbril]

It looks like you have some issues with your black installation. What does black --version print?

[Shashankjain12]

@OriolAbril do we need to create test cases as well manually I guess I had not created any maybe that's the problem?

[Shashankjain12]

And black, version is 18.9b0

[ahartikainen]

I think you need to update to latest version.

[Shashankjain12]

@ahartikainen even after updating black to 19.10b0 no file is changed at all

[OriolAbril]

@Shashankjain12 Somehow when you ran black, 32 extra files were reformatted (this is why now it says that this PR modifies 33 files), and they were reformatted in a way that the files cannot be parsed in python 3.5 (hence the build failure).

Somehow an old version of black is formatting the code, could there be 2 different installations? Otherwise you can try to code from within docker which will have the correct packages. We have a guide here that should help you.

[Shashankjain12]

So @OriolAbril do i need to delete my repo and try that again in order to contribute to this?

[OriolAbril]

You should not have to delete the whole repository, it looks like it only has to do with black.

Try uninstalling and reinstalling again just in case.

And if it does not work, using docker should allow to code from your computer on the same repo you already have but from within a container that has different programs available (inside which black should work properly)

[ahartikainen]

Hi @Shashankjain12 how have you installed your python? Are you using conda?

For example I use this workflow (with miniconda (+ cmder on Windows)) --> Use conda environment

https://pystan.readthedocs.io/en/latest/installation_beginner.html
https://pystan.readthedocs.io/en/latest/windows.html (<< conda stuff works for other OS too)

https://docs.conda.io/en/latest/miniconda.html <<- I use local folder e.g. "/home/miniconda3" and I add the conda on the PATH at installation step
https://cmder.net/

[OriolAbril]

@Shashankjain12 The changes in stats.py look great. Only plot_elpd needs to be updated now.

[Shashankjain12]

what is plot_elpd @OriolAbril ?

[OriolAbril]

plot_elpd

[Shashankjain12]

Ok sure thanks I will update that 👍

[Shashankjain12]

Done @OriolAbril 👍