cleanup: rm dead code for (feature = "man-pages") & recycle for a new (feature = "separate-binaries") #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryango
force-pushed
the
separate-binaries
branch
from
b94fec9
to
2563186
Compare
bryango
force-pushed
the
separate-binaries
branch
2 times, most recently
from
f5c3d49
to
cf4275a
Compare
bryango
force-pushed
the
separate-binaries
branch
2 times, most recently
from
e1a9e3c
to
d364a0a
Compare
bryango
force-pushed
the
separate-binaries
branch
from
d364a0a
to
2f724d7
Compare
bryango
force-pushed
the
separate-binaries
branch
2 times, most recently
from
74fa2c1
to
845e1f1
Compare
Notably, git is updated: 2.43 -> 2.46.
The feature has been removed since PR 205, so we remove the associated dead code to avoid confusion with the current implementation, i.e. the "install-man-pages" command.
Rename some leftover (feature = "man-pages") to "separate-binaries" which is more descriptive. This is still an un-implemented feature, but it could be revived in the future for better user experience.
bryango
force-pushed
the
separate-binaries
branch
from
845e1f1
to
8e8c91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was exploring the clap related code to see if we can generate completions, and accidentally came across some dead code on the removed "man-pages" feature. This patch:
man-pagesfeature #205. This avoids confusion with the current working implementation, namely the "install-man-pages" command.