Fix some test issues #1396
Merged
Fix some test issues #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
changed the title
test_man_viewer with test_help_flagtest_man_viewer with test_help_flag
arxanas
force-pushed
the
arxanas/fix-init-replace-broken-test-test-man-viewer-with-test-help-flag
branch
from
b98f0f5
to
6f0d53b
Compare
arxanas
changed the title
test_man_viewer with test_help_flag
…serveTimestamps true`
Not sure why, but failing to call `git-branchless-*` subcommands seems to cause an error in CI: https://github.com/arxanas/git-branchless/actions/runs/10754720519/job/29825644537?pr=1396 It might only be an issue with `--all-features`/the `man-pages` feature.
Only runs with the `man-pages` feature. Actually, the test is probably still logically broken, since it's no longer printing man-page content, but just normal help page content.
This was fixed by the `git2` upgrade from v0.18.3 to v0.19.0 in #1393.
It looks like at some point we deleted all the individual subcommand binaries that used to be built with the `man-pages` feature. This test therefore is no longer useful/valid.
arxanas
force-pushed
the
arxanas/fix-init-replace-broken-test-test-man-viewer-with-test-help-flag
branch
from
a1577f0
to
d650e43
Compare
It looks like Git on the GitHub Actions Windows CI runner was updated from v2.45 to v2.46 in image version `20240915.1.0` (see https://github.com/actions/runner-images/blob/e3b97844e5589424d845da8eabba9d2f73852577/images/windows/Windows2022-Readme.md). Tests are failing for v2.46 for git-branchless on all platforms (but that version is not currently part of the CI matrix for Linux). I don't have time to fix the tests for v2.46 right now, so this commit disables the tests for Windows. (It would also be possible to build and test against a specific version of Git on Windows, but I don't have time to figure that out either.)
arxanas
force-pushed
the
arxanas/fix-init-replace-broken-test-test-man-viewer-with-test-help-flag
branch
from
c81e7a1
to
79539ec
Compare
arxanas
deleted the
arxanas/fix-init-replace-broken-test-test-man-viewer-with-test-help-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.