Improve smartlog revset rendering

[arxanas]

No description provided.

[claytonrcarter]

Thank you for tinkering on this! Yes, I do find the output more intuitive. My couple of comments:

• Probably just a draft/temp thing, but it looks like hidden commits are included in the revset-filtered output even if --hidden is not passed in.

• Is it possible (or even desirable) to display the vertical ellipsis after commits in heads(revset) to indicate that that commit is not a head when the output is not filtered?

Unfortunately, I haven't come up with a way to support not showing the ancestor commits up to the main branch. Currently, it's a hard-coded assumption.

Would it be at all relevant to this problem (or feasible) to always show the HEAD commit, but to omit the commits between roots(revset) and HEAD and just display when w/ the vertical ellipsis? Maybe even always showing the current main branch commit?

Here's a mockup of what I'm wondering, given this smartlog:

⋮
◇ 0f06699 1d (master, remote origin/master) build: run `cargo upgrade`
┃
◯ 7e512e6 1d build(revset): build parser as part of `build.rs`
┃
◯ 87bc6fd 1d tests(eval): create `eval_and_sort` function
┃
◯ 96b891e 1d feat(revset): add `not` function
┃
◯ c9ec768 1d feat(revset): produce friendlier error messages
┣━┓
┃ ◯ 3793bfd 1d refactor(revset): rewrite grammar to support `:` as a mixfix operator
┃ ┃
┃ ◯ bc0c8b7 1d (arxanas/revset) feat(smartlog): support passing an arbitrary revset expression
┃
◯ 44282b9 7h refactor(revset): rewrite grammar to support `:` as a mixfix operator
┃
◯ dbb440e 7h feat(smartlog): support passing an arbitrary revset expression
┃
◯ 82c92b1 5h ci: raise test timeout
┃
◯ 57f00be 5h temp: smartlog improve branches() revset
┃
◯ d09305a 5h temp: set default revset
┃
● 9fd5eb3 5h (ᐅ arxanas/revset-2) temp: try to pass in references snapshot

Current

❯ cargo run -- smartlog 'children(c9ec768)'
⋮
◇ 0f06699 1d (master, remote origin/master) build: run `cargo upgrade`
┃
◯ 7e512e6 1d build(revset): build parser as part of `build.rs`
┃
◯ 87bc6fd 1d tests(eval): create `eval_and_sort` function
┃
◯ 96b891e 1d feat(revset): add `not` function
┃
◯ c9ec768 1d feat(revset): produce friendlier error messages
┣━┓
┃ ◯ 3793bfd 1d refactor(revset): rewrite grammar to support `:` as a mixfix operator
┃
◯ 44282b9 7h refactor(revset): rewrite grammar to support `:` as a mixfix operator
┃
◯ dbb440e 7h feat(smartlog): support passing an arbitrary revset expression
┃
◯ 82c92b1 5h ci: raise test timeout
┃
◯ 57f00be 5h temp: smartlog improve branches() revset
┃
◯ d09305a 5h temp: set default revset
┃
● 9fd5eb3 5h (ᐅ arxanas/revset-2) temp: try to pass in references snapshot

Maybe? 🤷

❯ cargo run -- smartlog 'children(c9ec768)'
⋮
◇ 0f06699 1d (master, remote origin/master) build: run `cargo upgrade`
⋮
┣━┓
┃ ◯ 3793bfd 1d refactor(revset): rewrite grammar to support `:` as a mixfix operator
┃ ⋮
┃
◯ 44282b9 7h refactor(revset): rewrite grammar to support `:` as a mixfix operator
⋮
● 9fd5eb3 5h (ᐅ arxanas/revset-2) temp: try to pass in references snapshot

[arxanas]

Haven't had time to work on this, so closing for now.