Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip test #21

Closed
wants to merge 6 commits into from
Closed

Gzip test #21

wants to merge 6 commits into from

Conversation

nodece
Copy link
Collaborator

@nodece nodece commented Jul 24, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

lhotari and others added 6 commits July 24, 2024 12:36
…eb server configuration (apache#14353)

* [Broker] Improve Jetty configuration to handle backpressure

- Fix maxConcurrentHttpRequests by using QoSFilter to limit concurrent requests
  - previous solution didn't limit concurrent http requests
- Replace previous hardcoded connection limit of 10000 http connections with configurable setting
  - use Jetty's built-in connection limit instead of PulsarServerConnector's custom solution
- Rate limiting should happen in the beginning of the filter chain
- Let Jetty tune selectors and acceptors based on number of cores
  - JETTY_AVAILABLE_PROCESSORS=n environment variable can be used to override the number of cores reported by the OS
    - This is useful when CPU limit isn't set on k8s and the number of cores is the number of total cores available on the k8s node
    - use can also use -XX:ActiveProcessorCount=n to make Java's Runtime.getRuntime().availableProcessors() return n
- Make accept queue capacity configurable
- Make thread pool queue capacity bounded and make it configurable

* [Functions] Add http backpressure handling for Functions worker's http server

(cherry picked from commit ec38211)
Signed-off-by: Zixuan Liu <[email protected]>
…r web server (apache#15637)

- There were filter instances for each context path which made
  maxConcurrentHttpRequests and httpRequestsMaxPerSecond not work as expected.
- Fixes the backpressure solution that is dependent on maxConcurrentHttpRequests and httpRequestsMaxPerSecond
  working properly
- Fix invalid Jersey api usage

(cherry picked from commit 94392a4)
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
@nodece
Copy link
Collaborator Author

nodece commented Jul 24, 2024

PASSED

@nodece nodece closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants