Make view
and view_method
nullable and shorter
#103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (finally!) just updated from a pre-1.0 version up to 1.4.0, and found that (1) it took over an hour to execute the migration and (2) it ate up almost 9GB of disk space. I do have about 12 million rows after all.
I figured, why not allow these values to be
None
/NULL
, as it seems the right value to use for old entries, but it also kinda works for when the code can't figure out either the view name or the view method.I.e. the answer to the question: "What view is this?" should be
None
, rather than the empty-string when the view can't be discerned, no?