Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make view and view_method nullable and shorter #103

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Make view and view_method nullable and shorter #103

merged 1 commit into from
Mar 29, 2018

Conversation

tomage
Copy link
Contributor

@tomage tomage commented Mar 21, 2018

I (finally!) just updated from a pre-1.0 version up to 1.4.0, and found that (1) it took over an hour to execute the migration and (2) it ate up almost 9GB of disk space. I do have about 12 million rows after all.

I figured, why not allow these values to be None/NULL, as it seems the right value to use for old entries, but it also kinda works for when the code can't figure out either the view name or the view method.

I.e. the answer to the question: "What view is this?" should be None, rather than the empty-string when the view can't be discerned, no?

@avelis
Copy link
Collaborator

avelis commented Mar 29, 2018

@triat Would you have any objections to this? I don't but just wanted to run it by someone else just in case.

@triat
Copy link
Contributor

triat commented Mar 29, 2018

@avelis So no I don't mind, my concern is more about the size of your DB growing which will, in any case, result in an impossible table to use because of the size. Therefore I would suggest using an ES maybe but that's not related to the issue.

DR; TL: it's ok for me

@avelis avelis merged commit e9d26f6 into aschn:master Mar 29, 2018
@tomage
Copy link
Contributor Author

tomage commented Mar 29, 2018

@triat Yeah - that's a definite concern coming up soon-ish (may start with pruning old entries).

Thanks for the approval guys, and thanks for the work you do on this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants