Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow basemodel reuse #108

Merged
merged 2 commits into from
Jul 27, 2018
Merged

Conversation

flupzor
Copy link
Contributor

@flupzor flupzor commented Apr 19, 2018

Add the ability to create your own APIRequestLog model based on the BaseAPIRequestLog without having to add 'drf-tracking' to INSTALLED_APPS.

Do this by splitting up models and mixins into base_models and base_mixins. base_models and base_mixins are the files you can use to
create your own models and mixins, and models and mixins are the modules you can use to for the normal use case.

@avelis
Copy link
Collaborator

avelis commented Jul 26, 2018

@flupzor Any chance you can resolve your conflicts and I can make the consideration for merging?

Alexander Schrijver added 2 commits July 27, 2018 10:23
…aseAPIRequestLog without having to add 'drf-tracking' to INSTALLED_APPS.

Do this by splitting up models and mixins into base_models and base_mixins. base_models and base_mixins are the files you can use to
create your own models and mixins, and models and mixins are the modules you can use to for the normal use case.
@flupzor
Copy link
Contributor Author

flupzor commented Jul 27, 2018

@avelis I just did.

@avelis avelis merged commit 99c595a into aschn:master Jul 27, 2018
@avelis
Copy link
Collaborator

avelis commented Jul 27, 2018

@flupzor Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants