Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch decode source encoding from ascii to utf-8 #130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

switch decode source encoding from ascii to utf-8 #130

wants to merge 3 commits into from

Conversation

freddez
Copy link

@freddez freddez commented Nov 22, 2018

UnicodeDecodeError fix on python 2.7 / django 1.11 #129

Tested with Python 2.7.15 / Django 1.11.16 and Python 2.3.7 / Django 2.1.3

@mrdaliri
Copy link

Could you please update it with latest master branch? Another parameter (errors='replace') has been added to data.decode().

@martync
Copy link

martync commented Aug 27, 2019

Hi !
I was wondering if there's something blocking this pull-request. I saw a pyFlake error on travis , how can I help ?

@avelis
Copy link
Collaborator

avelis commented Aug 27, 2019

@martync Fix the pyFlake would help here I think. It also has merge conflicts.

@martync
Copy link

martync commented Aug 28, 2019

I can't reproduce this error at home nor on travis : tests/test_mixins.py:385:13: E117 over-indented

I have another failure that concerns pypi (which is normal) : https://github.com/martync/drf-tracking/commits/master but no pyflake errors here 🤔

@avelis can you re-trigger this travis build ? If it still fails, I'll make a pull request from my repo

@avelis
Copy link
Collaborator

avelis commented Aug 28, 2019

@martync I restarted it. You can follow its progress here: https://travis-ci.org/aschn/drf-tracking/builds/531659171

@martync
Copy link

martync commented Nov 27, 2019

Hi @avelis any chance you have time to create a new release with this fix ?

@avelis
Copy link
Collaborator

avelis commented Nov 27, 2019

@martync I can try and take a look after the holiday break.

@avelis
Copy link
Collaborator

avelis commented Dec 21, 2019

@martync This needs a rebase in order to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants