Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consume streaming response content #137

Merged
merged 2 commits into from
May 14, 2019
Merged

Don't consume streaming response content #137

merged 2 commits into from
May 14, 2019

Conversation

rib3
Copy link
Contributor

@rib3 rib3 commented May 13, 2019

Check for streaming response, if so do not consume content

@rib3
Copy link
Contributor Author

rib3 commented May 14, 2019

rebased now that #138 has been merged

@avelis avelis merged commit 8d39387 into aschn:master May 14, 2019
@rib3 rib3 deleted the streaming-response branch May 14, 2019 18:29
@rib3
Copy link
Contributor Author

rib3 commented May 14, 2019

@avelis

Is this a good time to cut 1.5.1 and publish to pypi?
#132 contains another fix that was merged after 1.5.0. (Looks like a few people have commented about it via #134)

@avelis
Copy link
Collaborator

avelis commented May 14, 2019 •
edited
Loading

@rib3 Good idea. Busy today. Will look into it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rib3 @avelis