-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #37, add the CLI version and the Asciidoctor.js version #39
Conversation
What's confusing is there are 3 Asciidoctor references. Whereas there are 3 different purposes:
|
I don't really think the CLI version is necessary. It really should be just a thin wrapper that rarely, if ever, needs to be referenced. (If so, you can check the deps tree). What matters is the version of Asciidoctor.js and which Asciidoctor core version it's using. I might also rephrase "built from" to be "powered by" or "compliant with". The user doesn't care what it's built with, but rather what it is running. So it's all in how we frame it. |
I somewhat agree but as mentioned by @oncletom it can be useful for bug reports. It may be because we are at an early stage but the CLI is still evolving and has a few bugs/missing features.
Since Asciidoctor.js is not a direct dependency anymore, we can't infer the version of Asciidoctor.js from the CLI version. But we can infer the version of Asciidoctor Ruby from the version of Asciidoctor.js.
The version of Asciidoctor core can be infer (from Asciidoctor.js) and it might be confusing.
(I'm using version 2.0.0 because the version of the CLI is not aligned on the version of Asciidoctor.js anymore) |
I like this.
… |
What do you think @oncletom of the last proposal ? |
6d6f3a1
to
e6bb4e0
Compare
Done:
|
Should we keep
(built using Asciidoctor 1.5.8)
?I think the CLI version is important but maybe it's confusing ?
[EDIT]
What about: