Defined an idprefix to avoid reveal.js bug #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in reveal.js that causes problems, when ids start with non-ascii-characters, although it is perfectly legal html5. Setting the ``idprefix`` avoids this problem and I think therefore this should be used as the default in the example.
|
I support this change. Using a blank idprefix is risk for a few reasons. In addition to getting IDs that start with non-ASCII characters (legal HTML5, but not supported by reveal.js), you also run the risk of getting an ID that conflicts with built-in IDs on the page / template (e.g., header/footer). Generally, it's a good idea to use a non-blank idprefix. Note that the default idprefix is underscore for this very reason. |
|
Thank you for your PR @schauder! This is now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in reveal.js that causes problems, when ids start with non-ascii-characters, although it is perfectly legal html5. Setting the
idprefixavoids this problem and I think therefore this should be used as the default in the example.See also:
hakimel/reveal.js#1346
hakimel/reveal.js#1230
asciidoctor/asciidoctor-reveal.js#32