-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(main) Bump Asciidoctorj to v3.0.x #651
Merged
abelsromero
merged 1 commit into
asciidoctor:main
from
abelsromero:bump-asciidoctorj-v3.0.x
Oct 6, 2024
Merged
(main) Bump Asciidoctorj to v3.0.x #651
abelsromero
merged 1 commit into
asciidoctor:main
from
abelsromero:bump-asciidoctorj-v3.0.x
Oct 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
2 times, most recently
from
June 15, 2023 21:32
89712c1
to
d487882
Compare
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
5 times, most recently
from
June 18, 2023 07:34
ed339d9
to
af626e2
Compare
abelsromero
changed the title
Bump asciidoctorj v3.0.x
(experimental) Bump asciidoctorj v3.0.x
Nov 26, 2023
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
2 times, most recently
from
December 26, 2023 22:08
860dd15
to
134acb6
Compare
abelsromero
changed the title
(experimental) Bump asciidoctorj v3.0.x
(main) (experimental) Bump asciidoctorj v3.0.x
Dec 27, 2023
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
from
December 29, 2023 18:49
134acb6
to
dd2a2d7
Compare
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
2 times, most recently
from
October 5, 2024 18:43
0faf08f
to
07d3cf6
Compare
abelsromero
changed the title
(main) (experimental) Bump asciidoctorj v3.0.x
(main) Bump asciidoctorj v3.0.x
Oct 6, 2024
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
from
October 6, 2024 19:20
7361083
to
7e0e76e
Compare
abelsromero
changed the title
(main) Bump asciidoctorj v3.0.x
(main) Bump Asciidoctorj to v3.0.x
Oct 6, 2024
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
from
October 6, 2024 19:31
7e0e76e
to
a8dca2d
Compare
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
from
October 6, 2024 19:39
a8dca2d
to
fb48c3b
Compare
abelsromero
force-pushed
the
bump-asciidoctorj-v3.0.x
branch
from
October 6, 2024 19:54
fb48c3b
to
63adeac
Compare
Fix to_dir setting in tests Fix baseDir pathing in site converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental branch to test changes for Asciidoctorj v3.0.x (not for merging yet).Bump Asciidoctorj to v3.0.x:
toDir
forAsciidoctorMojo
andbaseDir
for Site Converter need to be absolute.ℹ️ I run additional manual tests on AsciidoctorJ 2.5.13 and all is working fine since AsciidoctorJ v3 is binary compatible with 2.5.x 🎉
NOTE: in case someone saw the previous description listing breaking changes, those no longer apply since they were already addressed in maven-plugin 3.0.0 or are internals that don't break the XML configuration of the Maven plugin 😌