Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(main) Bump Asciidoctorj to v3.0.x #651

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jun 14, 2023

Experimental branch to test changes for Asciidoctorj v3.0.x (not for merging yet).

Bump Asciidoctorj to v3.0.x:

  • Fix pathing issues related to Reuse Asciidoctor Ruby invoker asciidoctorj#1249. TLDR; toDir for AsciidoctorMojo and baseDir for Site Converter need to be absolute.
  • Tests
    • Update extensions examples used for integration testing
    • Fix pathing issues (same as above ☝️ )
    • Fix use of deprecated Options and Attributes builders in 'asciidoctor-converter-doxia-module'

ℹ️ I run additional manual tests on AsciidoctorJ 2.5.13 and all is working fine since AsciidoctorJ v3 is binary compatible with 2.5.x 🎉

NOTE: in case someone saw the previous description listing breaking changes, those no longer apply since they were already addressed in maven-plugin 3.0.0 or are internals that don't break the XML configuration of the Maven plugin 😌

@abelsromero abelsromero force-pushed the bump-asciidoctorj-v3.0.x branch 2 times, most recently from 89712c1 to d487882 Compare June 15, 2023 21:32
@abelsromero abelsromero added the dependencies Pull requests that update a dependency file label Jun 16, 2023
@abelsromero abelsromero force-pushed the bump-asciidoctorj-v3.0.x branch 5 times, most recently from ed339d9 to af626e2 Compare June 18, 2023 07:34
@abelsromero abelsromero changed the title Bump asciidoctorj v3.0.x (experimental) Bump asciidoctorj v3.0.x Nov 26, 2023
@abelsromero abelsromero force-pushed the bump-asciidoctorj-v3.0.x branch 2 times, most recently from 860dd15 to 134acb6 Compare December 26, 2023 22:08
@abelsromero abelsromero changed the title (experimental) Bump asciidoctorj v3.0.x (main) (experimental) Bump asciidoctorj v3.0.x Dec 27, 2023
@abelsromero abelsromero force-pushed the bump-asciidoctorj-v3.0.x branch 2 times, most recently from 0faf08f to 07d3cf6 Compare October 5, 2024 18:43
@abelsromero abelsromero changed the title (main) (experimental) Bump asciidoctorj v3.0.x (main) Bump asciidoctorj v3.0.x Oct 6, 2024
@abelsromero abelsromero marked this pull request as ready for review October 6, 2024 18:51
@abelsromero abelsromero changed the title (main) Bump asciidoctorj v3.0.x (main) Bump Asciidoctorj to v3.0.x Oct 6, 2024
Fix to_dir setting in tests
Fix baseDir pathing in site converter
@abelsromero abelsromero merged commit fee9c89 into asciidoctor:main Oct 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.0 dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant