Support "Captioned titles" in asciidoctor-parser-doxia-module #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
abelsromero
force-pushed
the
branch-main/749/add-captioned-titles-support-to-parser-doxia-module
branch
from
c7b8937
to
24e2365
Compare
# Conflicts: # asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/parser/NodesSinker.java # asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/parser/processors/ListingNodeProcessor.java # asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/parser/processors/TableNodeProcessor.java
abelsromero
force-pushed
the
branch-main/749/add-captioned-titles-support-to-parser-doxia-module
branch
from
48ec5d4
to
0e47d66
Compare
abelsromero
force-pushed
the
branch-main/749/add-captioned-titles-support-to-parser-doxia-module
branch
from
802a190
to
8459943
Compare
abelsromero
force-pushed
the
branch-main/749/add-captioned-titles-support-to-parser-doxia-module
branch
from
14dc6f0
to
77b67c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP:
Working on examples made me realize the way we traverse the AST won't work.
We did some workaround for lists, making it so sub-blocks are traversed from a dedicated NodeProcessor.
But we can't apply the same for example, because it can contain many other elements.
🤔
I will probably merge basic support for example nodes with a paragraph first and then work on the refactoring in another PR. This is experimental after all.👉 Done and rebased #944What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Are there any alternative ways to implement this?
Are there any implications of this pull request? Anything a user must know?
Is it related to an existing issue?
Fixes #749