Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded bold for first line of abstract #378

Closed
nawroth opened this issue Dec 21, 2015 · 1 comment
Closed

Hardcoded bold for first line of abstract #378

nawroth opened this issue Dec 21, 2015 · 1 comment
Assignees
@nawroth
Labels
improvement
Milestone
v1.5.0.alpha.11

Comments

@nawroth
Copy link
Contributor

nawroth commented Dec 21, 2015

This means that font styling can't really be used for abstract, it will look silly for any setting other than bold. For styling of the first line altering the indentation might make sense in some cases, but why a different font style would be used makes no sense to me!

It would be an improvement to simply drop first_line_options in this context. It could then be re-introduced with more flexibility and controlled from the theme later on.

Code is here:
https://github.com/asciidoctor/asciidoctor-pdf/blob/master/lib/asciidoctor-pdf/converter.rb#L339
nawroth added a commit to nawroth/asciidoctor-pdf that referenced this issue Dec 21, 2015
@nawroth
Remove hardcoded bold font for first line in abstract
af893bf 
The feature could be re-introduced with theming support later on.
As it stands before this change, it limits the styling of abstract blocks too much.

Fixes asciidoctor#378.
@nawroth nawroth mentioned this issue Dec 21, 2015
Merged
nawroth added a commit to nawroth/asciidoctor-pdf that referenced this issue Dec 22, 2015
@nawroth
Control font style of first line of abstract from theme
294b452 
Fixes asciidoctor#378.
@mojavelinux
Copy link
Member

As discussed in the pull request, we'll introduce a theme setting named abstract_first_line_font_style to allow this setting to be configured.

@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Dec 22, 2015
nawroth added a commit to nawroth/asciidoctor-pdf that referenced this issue Dec 22, 2015
@nawroth
Control font style of first line of abstract from theme
cf61a2e 
Fixes asciidoctor#378.
nawroth added a commit to nawroth/asciidoctor-pdf that referenced this issue Dec 22, 2015
@nawroth
Control font style of first line of abstract from theme
d510cc7 
Fixes asciidoctor#378.
nawroth added a commit to nawroth/asciidoctor-pdf that referenced this issue Dec 23, 2015
@nawroth
Control font style of first line of abstract from theme
07d7906 
Fixes asciidoctor#378.
mojavelinux added a commit that referenced this issue Dec 23, 2015
@mojavelinux
Merge pull request #379 from nawroth/fix-abstract-font-styling
adeb26c 
resolves #378 Remove hardcoded bold font for first line in abstract
@mojavelinux mojavelinux changed the title Harcoded bold for first line of abstract Hardcoded bold for first line of abstract Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nawroth nawroth

Labels
improvement
Projects
None yet
Milestone
v1.5.0.alpha.11
Development

No branches or pull requests
2 participants
@mojavelinux @nawroth