Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extensionless image URIs or image URIs that contain a query string #540

Closed
mojavelinux opened this issue Sep 5, 2016 · 0 comments
Closed

Support extensionless image URIs or image URIs that contain a query string #540

mojavelinux opened this issue Sep 5, 2016 · 0 comments
Assignees
@mojavelinux
Labels
improvement
Milestone
v1.5.0.alpha.13

Comments

@mojavelinux
Copy link
Member

Support extensionless image URIs or image URIs that contain a query string by honoring the format attribute.

For example:

image::https://img.shields.io/badge/style-flat-green.svg?style=flat[format=svg]

The converter should consult the format attribute first, then fall back to extracting the extension from the path.
@mojavelinux mojavelinux added this to the v1.5.0.alpha.13 milestone Sep 5, 2016
@mojavelinux mojavelinux self-assigned this Sep 5, 2016
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Sep 5, 2016
@mojavelinux
resolves asciidoctor#540 allow image type to be specified using forma…
462c43b 
…t attribute
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Sep 5, 2016
@mojavelinux
resolves asciidoctor#540 allow image type to be specified using forma…
5f42d07 
…t attribute
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Sep 6, 2016
@mojavelinux
resolves asciidoctor#540 allow image type to be specified using forma…
3951f4d 
…t attribute
fapdash pushed a commit to vogellacompany/asciidoctor-pdf that referenced this issue Dec 13, 2016
@mojavelinux @fapdash
resolves asciidoctor#540 allow image type to be specified using forma…
6b687ed 
…t attribute (PR asciidoctor#541)

* allow image type to be specified using format attribute
* use the term "format" instead of "type" to refer to image format
* resolves asciidoctor#494 prevent inline SVG from changing document font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement
Projects
None yet
Milestone
v1.5.0.alpha.13
Development

No branches or pull requests
1 participant
@mojavelinux