Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prawn-templates #803

Closed
MaWiMa opened this issue Apr 5, 2017 · 2 comments
Closed

prawn-templates #803

MaWiMa opened this issue Apr 5, 2017 · 2 comments

Comments

@MaWiMa
Copy link

MaWiMa commented Apr 5, 2017

Please change asciidoctor-pdf.gemspec line 46, to deal with prawn 2.2.2 and prawn-templates 0.1.1
I tried it locally and it does work.

s.add_runtime_dependency 'prawn-templates', '>= 0.0.3', '<= 0.1.1'

@mojavelinux
Copy link
Member

In order to make this change, we also need to document how to install Asciidoctor PDF on Ruby 2.0 (since Prawn 2.2 requires Ruby 2.1). We just need to make sure people have a path to being able to install and use Asciidoctor PDF back to Ruby 1.9.3 (which is the older version of Ruby we support).

See https://github.com/asciidoctor/asciidoctor-pdf#prerequisites

@mojavelinux
Copy link
Member

I am a little frustrated that prawn-templates forces the use of Prawn 2.2. I think that's really unnecessary that an extension forces a choice of core...but that's really out of our control.

@mojavelinux mojavelinux self-assigned this Apr 5, 2017
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants