Set default page size to A4 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| # encoding: UTF-8 | |||
| # encoding: utf-8 | |||
There was a problem hiding this comment.
This probably shouldn't be part of this PR.
There was a problem hiding this comment.
I agree. Ruby stores encoding names internally in uppercase, so technically UTF-8 is more correct (though both cases work).
There was a problem hiding this comment.
Apologies. My editor changed that automatically and I missed it.
|
Thanks! The change to the page_size is correct. Could you revert the encoding line, amend the commit ( |
Resolves asciidoctor#319. Visually confirmed in Evince: File > Properties.
|
This has been done. |
|
Nice work again @stephenhay! |
mojavelinux
added a commit
that referenced
this pull request
Dec 16, 2015
Set default page size to A4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #319.
Visually confirmed in Evince: File > Properties.