Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout with :icons: font not styled as ball #168

Closed
dschulten opened this issue Dec 26, 2017 · 2 comments
Closed

Callout with :icons: font not styled as ball #168

dschulten opened this issue Dec 26, 2017 · 2 comments

Comments

@dschulten
Copy link
Contributor

dschulten commented Dec 26, 2017

With :icons: font the callout is not shown with a number icon.

The rendered markup is

<i class="conum" data-value="1"></i>
<b>(<span class="hljs-number">1</span>)</b>

It is shown as (1), not as a number "ball".
Reason: The original asciidoc.css contains the following style for conum[data-value], but that css is not included with a revealjs presentation. The original style hides the (1) and shows a number "ball" instead:

<style>
.conum[data-value]{display:inline-block;color:#fff!important;background-color:rgba(50,150,50,.8);-webkit-border-radius:100px;border-radius:100px;text-align:center;font-size:.75em;width:1.67em;height:1.67em;line-height:1.67em;font-family:"Open Sans","DejaVu Sans",sans-serif;font-style:normal;font-weight:bold}
.conum[data-value] *{color:#fff!important}
.conum[data-value]+b{display:none}
.conum[data-value]:after{content:attr(data-value)}
pre .conum[data-value]{position:relative;top:-.125em}
b.conum *{color:inherit!important}
.conum:not([data-value]):empty{display:none}
</style>

Suggestion: document in the readme that setting :customcss: and adding an asciidoctor-reveal.css file with the above style gets you number balls.

@obilodeau
Copy link
Member

There are several things that we don't support yet that will require us to inline some of asciidoctor's CSS. Until now I wasn't focused on doing these but I think we are there now.

I'll try to address these compliance bugs in our next feature release. Until then, this issue documents a workaround pretty clearly.

@obilodeau obilodeau added this to the 1.2.0 milestone Dec 27, 2017
@dschulten
Copy link
Contributor Author

OK, then I won't write a pull request for the readme :)

@obilodeau obilodeau modified the milestones: 2.1.0, 2.0.0 Nov 13, 2018
obilodeau added a commit that referenced this issue Nov 14, 2018
Source callout icons now work. Fixes #168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants