Duplicated section IDs

[mshibanami]

Input:

== hello こんにちは

Slide 1

== hello 你好

Slide 2

Output:

<div class="reveal">
  <div class="slides">
    <section id="hello_"><h2>hello こんにちは</h2><div class="paragraph"><p>Slide 1</p></div></section>
    <section id="hello_"><h2>hello 你好</h2><div class="paragraph"><p>Slide 2</p></div></section>
  </div>
</div>

Probably hello_ and hello_2 would be better than the double hello_.

(As a workaround, I add [id=...] to the previous line of titles.)

[mojavelinux]

The converter is simplifying the id that Asciidoctor generators to work with Reveal.js. However, in doing so, it's not checking if the ID it produces has already been used. The relevant code is here: https://github.com/asciidoctor/asciidoctor-reveal.js/blob/master/templates/section.html.slim#L5

This is case where support for the ascii-ids attribute could be useful in Asciidoctor core (something AsciiDoc Python supports). I didn't really have a use case for it before, but this would be one such example.

[obilodeau]

Upstream fixed hakimel/reveal.js#1230, so we can remove our filter which causes the name collision. This would avoid many of the collisions I believe.

Targeting next release for that workaround removal / fix.

[obilodeau]

PR submitted: #232