docinfo.html is not inserted

[timothypratley]

Expected:
Including a docinfo.html file and a :docinfo: shared attribute should cause it to appear in the html output.

Actual:
HTML is not inserted.

Workaround:
I am able to ln -s docinfo.html docinfo-header.html
Then the html is inserted into head.
i.e.: file must be called docinfo-header.html to be inserted, which contradicts the documentation in asciidoctor user manual.

I discovered this workaround on observing that the code is looking for header here:

asciidoctor-reveal.js/templates/document.html.slim

Line 72 in 6d700b9

- unless (docinfo_content = docinfo :header, '.html').empty?

There is related and conflicting information here:
asciidoctor/asciidoctor#1510

My repo demonstrating the problem:
https://github.com/timothypratley/enterprise-clojure-training

[mojavelinux]

Please see https://github.com/asciidoctor/asciidoctor-bespoke/blob/master/templates/slim/document.html.slim for the correct way to support docinfo in the reveal.js converter. Specifically:

        - unless (_docinfo = docinfo :header, '-reveal.html').empty?
          =_docinfo

...

        - unless (_docinfo = docinfo :header, '-reveal.html').empty?
          =_docinfo

...

      - unless (_docinfo = docinfo :footer, '-reveal.html').empty?
        =_docinfo

I believe we should look for the -reveal.html qualifier to avoid conflicting with the docinfo file used for the HTML output. wdyt?

[timothypratley]

According to https://asciidoctor.org/docs/user-manual/#naming-docinfo-files conflicts can be avoided by using the private naming scheme. Thus if I wanted to have a docinfo only apply to slides I would call it slides-docinfo.html and set the :docinfo: private attribute. I think that when :docinfo: shared is set then docinfo.html should be included in the slides head.

Right now I am using docinfo.html as a shared location to set a favicon that is used in both slides output and a book/manual output. I can see that sometime you would want to include javascript specific to the slides.

I am new to asciidoctor and .slim so my apologies if I am misunderstanding. I'm very grateful that it is capable of so many things. Just raising the issue to improve the ability of new users to make use of it :)

[mojavelinux]

According to asciidoctor.org/docs/user-manual/#naming-docinfo-files conflicts can be avoided by using the private naming scheme. Thus if I wanted to have a docinfo only apply to slides I would call it slides-docinfo.html and set the :docinfo: private attribute.

That's still not sufficient to support the goal of a single source document. Some users want to be able to generate an article and slides from the same document. But the docinfo file wouldn't be able to tell the difference.

What we could do is introduce the idea of a docinfo qualifier. The reveal.js and bespoke converters would set this by default, but it would still be possible to nullify it using at attribute assignment. That would give us the best of both worlds.

[mojavelinux]

To clarify, you are absolutely right to raise this issue. I'm simply suggesting that we bring the behavior into alignment with the bespoke converter.

[timothypratley]

I see. Yes, that sounds perfect! :)