-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load highlight.js from a CDN #21
Comments
I agree the version in the reveal.js plugin is outdated, see: hakimel/reveal.js#2562 We should use a copy of https://github.com/hakimel/reveal.js/blob/master/plugin/highlight/highlight.js without highlight.js. @obilodeau What do you think? The downside is that we will need to sync this file when we upgrade reveal.js. |
Not sure about the CDN part, considering that we are using a local copy of reveal.js but otherwise 👍 |
I was never particularly affected by this so don't have a big incentive for this. That said, I don't mind merging it. Just make sure changes to the release process are documented. Like looking at upstream (both reveal.js' integration and highlight.js) and merging back before releases, etc. Edit: my previous wording wrongly reflected that I didn't really care |
* Allows us to load it from a CDN (resolves #21) * Rely on a smaller core and allow the load of additional languages (a breaking change)
Load highlight.js from a CDN like we do with the HTML5 output instead of using the bundled version. Of course, we can still recognize the property of highlightjs dir so that it's possible to use the bundled version, but we should be consistent with the HTML5 output by default.
The text was updated successfully, but these errors were encountered: