Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source highlighter rouge is not working with asciidoctorj 2.0.0 #261

Closed
eiswind opened this issue May 13, 2019 · 3 comments
Closed

source highlighter rouge is not working with asciidoctorj 2.0.0 #261

eiswind opened this issue May 13, 2019 · 3 comments

Comments

@eiswind
Copy link
Contributor

eiswind commented May 13, 2019

<sourceHighlighter>rouge</sourceHighlighter>
<attributes>
<rouge-css>style</rouge-css>

I tried with asciidoctor-revealjs 2.0.0 and revealjs 3.5.0 as suggested in the asciidoctor maven examples.

It renders as

<pre class="highlight listingblock"><code class="java language-java">

I expected rouge support to be working with revealjs.

@bentolor
Copy link
Contributor

bentolor commented Jun 26, 2019

This is plainly, because reveal.js itselfs only bundles monokai.css and zenburn.css.

You need to add new themews into reveal.js/lib/css/

Alternatively directly link to the CSS, i.e. like:

:highlightjs-theme: https://highlightjs.org/static/demo/styles/atom-one-light.css

ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 9, 2019
…d in Asciidoctor 2.0.0

If syntax_highlighter method is not available fallback to the "legacy" custom syntax highlighting.
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 9, 2019
…d in Asciidoctor 2.0.0

If syntax_highlighter method is not available fallback to the "legacy" custom syntax highlighting.
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 9, 2019
…d in Asciidoctor 2.0.0

If syntax_highlighter method is not available fallback to the "legacy" custom syntax highlighting.
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 10, 2019
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 10, 2019
ggrossetie added a commit to ggrossetie/asciidoctor-reveal.js that referenced this issue Dec 10, 2019
@obilodeau obilodeau added this to the 3.0.0 milestone Dec 10, 2019
obilodeau added a commit that referenced this issue Dec 10, 2019
…i-2-0

 resolves #261 use the new syntax highlighter API
@obilodeau
Copy link
Member

Fixed by merging #287. Will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants