fix: only use lowercase asciidoc attributes #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is out of my control
|
This was referenced Jun 26, 2019
|
hi! any progress regarding this PR by any chance? asciidoctor-reveal.js is a little difficult to use without this fix, unfortunately. thanks and good luck :) |
obilodeau
reviewed
Nov 27, 2019
Asciidoctor currently does only support/expect attributes to be in lower case. Unfortunately the code expected attributes like ealjs_defaultTiming which were never actually resolved and always provided the default value
bentolor
force-pushed
the
fix/broken-attribute-casing
branch
from
06ecf94
to
134bf3d
Compare
|
Rebased to retrigger build with false-positive build failure: Now everything green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asciidoctor currently does only support/expect attributes to be
in lower case. Unfortunately the code expected attributes like
ealjs_defaultTiming which were never actually resolved and
always provided the default value