Only include the relevant part when using doctest #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually we do have tests (see: revealjs-features.html) so I'm not sure how #267 passed through the tests suite 🤔 |
Update Gem description and summary
|
Note: failing Travis tests are not related to our project |
Example showcase project, part of asciidoctor#262
npm should be lowercase and the S in JavaScript should be uppercase
As discussed, tracking current latest stable instead of `jruby-head` which includes snapshots and unstable versions. Co-Authored-By: Guillaume Grossetie <[email protected]>
Attempt at fixing recent Travis JRuby build failures
|
Good to go |
|
For the record, tests were failing, they were fixed in another commit so I merged with master to see if tests were good. The PR doesn't look so good now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
:include:directive to avoid copy-pasting the reveal.js inline script and the inline Asciidoctor default style.I think we should have specific tests on the reveal.js inline script (to make sure that #267 won't happen again). I will do another pull request for that.