Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #29 add table styles #288

Merged
merged 1 commit into from
Dec 10, 2019
Merged

resolves #29 add table styles #288

merged 1 commit into from
Dec 10, 2019

Conversation

ggrossetie
Copy link
Member

resolves #29 #42 #56

@ggrossetie
Copy link
Member Author

Default Aligns Grid none, frame none
table-default aligns grid-none-frame-none
Frame none Frame sides Frame topbot
frame-none frame-sides frame-topbot
Grid none Grid cols Grid rows
grid-none grid-cols grid-rows

@obilodeau
Copy link
Member

This is amazing! 👍 for the example and the screenshots!

I think that by merging #287 I caused conflicts. Since you worked on both these PR recently, can you update here to fix the conflicts please?

@ggrossetie
Copy link
Member Author

Conflicts resolved, should I add an entry to the changelog?

@obilodeau
Copy link
Member

Don't do the changelog, I can take care of it.

@obilodeau obilodeau merged commit 2a0035d into asciidoctor:master Dec 10, 2019
@obilodeau obilodeau mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables do not listen to "grid" and "frames" options
2 participants
@ggrossetie @obilodeau