Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #158: Use section title (with sectnums) #317

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Issue #158: Use section title (with sectnums) #317

merged 3 commits into from
Jan 23, 2020

Conversation

eiswind
Copy link
Contributor

@eiswind eiswind commented Jan 22, 2020

I found that in helpers.rb the section_title was already defined with sectnum support.
I'm not sure if it is as simple as that, but I changed the section template to use this helper.

@ggrossetie
Copy link
Member

Seems to be working as expected but you will need to update the tests:

  • test/doctest/outline.html
  • test/doctest/section.html

See: https://travis-ci.org/asciidoctor/asciidoctor-reveal.js/jobs/640352964

@eiswind
Copy link
Contributor Author

eiswind commented Jan 22, 2020

Thanks for the hint :) There are tests...

@obilodeau
Copy link
Member

Looking good! Awesome that helpers.rb already provided that.

Can you create a simple AsciiDoc file in examples/ that demonstrates the feature in a minimal way and with accompanying doctest.

I don't think README documentation is necessary since this is an upstream documented feature of the language that we will now support.

@eiswind
Copy link
Contributor Author

eiswind commented Jan 22, 2020

just added a simple example ..

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to do a good PR!

@obilodeau obilodeau merged commit 06022fd into asciidoctor:master Jan 23, 2020
@eiswind eiswind deleted the issue/#185 branch February 2, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants