Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #276 add the kdb style #329

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Feb 9, 2020

Here's how it looks:

kbd

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring with adding new functionality in a single commit makes it harder to assess if there's no regression silently introduced. Try to split both next time around.

I will diff the files with master once this is rebased to make sure nothing was reverted by mistake (since we touched the CSS along the way).

templates/document.html.slim Outdated Show resolved Hide resolved
@ggrossetie
Copy link
Member Author

Refactoring with adding new functionality in a single commit makes it harder to assess if there's no regression silently introduced. Try to split both next time around.

I can split the changes no worries.

@obilodeau obilodeau added this to the 4.0.0 milestone Feb 10, 2020
@obilodeau
Copy link
Member

I can split the changes no worries.

This was done in #330 and merged. Time to rebase 🙂

@ggrossetie
Copy link
Member Author

@obilodeau Done! I've edited my first comment to add a screenshot.

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Can you add that example in examples/ and generate the appropriate doctest, please?

@ggrossetie
Copy link
Member Author

Can you add that example in examples/ and generate the appropriate doctest, please?

@obilodeau There's already an example and a doctest named "keyboard-shortcuts"

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obilodeau There's already an example and a doctest named "keyboard-shortcuts"

Did I say something? 😉

@obilodeau obilodeau merged commit 14d683b into asciidoctor:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants