Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use content_for and yield_content to remove code duplication #333

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Use content_for and yield_content to remove code duplication #333

merged 1 commit into from
Feb 11, 2020

Conversation

ggrossetie
Copy link
Member

No description provided.

obilodeau
obilodeau approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this is neat! Pretty compact and clever code that I wouldn't have been able to write myself.

@obilodeau obilodeau merged commit b0b9f4f into asciidoctor:master Feb 11, 2020
obilodeau added a commit to ggrossetie/asciidoctor-reveal.js that referenced this pull request Feb 11, 2020
@obilodeau
Fixed conflict with asciidoctor#333 in asciidoctor#332
fa6a079
@obilodeau obilodeau mentioned this pull request Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obilodeau obilodeau obilodeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggrossetie @obilodeau