Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop thread_safe and concurrent-ruby dependencies #421

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

slonopotamus
Copy link
Contributor

@slonopotamus slonopotamus commented Feb 27, 2021

Seems like they serve no purpose in asciidoctor-reveal.js and most likely are artifacts from ancient Ruby versions

Seems like they serve no purpose and most likely are artifacts from ancient Ruby versions
@ggrossetie
Copy link
Member

Seems like they serve no purpose in asciidoctor-reveal.js and most likely are artifacts from ancient Ruby versions

I think you are right!
For reference, Dan said:

For compatibility with 1.5.8, you should add a dependency on the concurrent-ruby gem. You can still depend on thread_safe too. As long as both gems are present, it will work on both 1.5.7 and 1.5.8 without any warnings.

Asciidoctor core has a policy of having 0 dependencies. On top of that, it's only a recommended dependency, not a required one.

(^^^ speaking about thread_safe dependency)

And, btw, it's now concurrent-ruby, not thread_safe. Though, for it to work without warning on both 1.5.7 and 1.5.8, you'll need both on the load path.

@ggrossetie ggrossetie merged commit 66916b8 into asciidoctor:master Feb 27, 2021
@ggrossetie
Copy link
Member

Thanks, less dependencies is 💚

@slonopotamus slonopotamus deleted the cleanup-deps branch February 27, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants