-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video support improvements #81
Conversation
Great work!
I'd prefer to stick to the terminology from CSS where possible. CSS offers two sizing keywords, "contain" and "cover". They both give you ways to fit the object to the canvas. I think we should use those names instead (in fact, it might even be better to use CSS rules instead of width and height attributes). |
I haven't made up the name. The .stretch class is provided by reveal.js and is applied via javascript to the HTML tag with it. That said, you are right, we should try to have a CSS solution instead. |
Added task:
|
Fixed video options=autoplay.
|
I wasn't aware Reveal.js provided the stretch class. In that case, we do want to be able to provide access to all underlying features, so 👍 to supporting both ways of expressing it. |
And fixed the same for height
cab1035
to
8e94735
Compare
|
I have tried several CSS instructions and I wasn't able to achieve the same result as what revealjs' stretch class does on youtube iframes. I tried several combinations of min-height, height and positioning things and nothing worked. However I have to admit I'm not that skilled with CSS... @mojavelinux any idea what should be done to avoid revealjs' stretch class here? For context, that solution relies on javascript to alter the DOM to specify the height and width (in pixels) to the div containing the iframe. Other than that, the |
Made several improvements to the support and documentation around videos. Fixes #71.
[.stretch]
)The PR is larger than it should because I branched it from
data-background-rework
and rebased it from master before pushing. Once #52 is merged, I'll rebase again on master and reviewing should be a lot more straightforward.Task list:
.stretch
class to make video large (100% or cover/contain sizes?)options="autoplay"
makes the video start at prefetch time which is too soon