Changed regex, so it does not remove first letter of id #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JacobAae! That is definitely the regexp we want. @obilodeau this looks correct to me (in fact, it's very critical). |
|
With the Gradle/Jruby plugin, it broke the navigation. The solution is based on this issue: hakimel/reveal.js#1230 |
obilodeau
added a commit
that referenced
this pull request
Sep 23, 2016
|
Tested and you are correct. Behavior was broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex removes the first character of the title in the id, making
== P2P Applications
have "2p-applications" as id, failing in navigation, as it starts with a number.