Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodecli): update to marked@14 #1760

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix(nodecli): update to marked@14 #1760

merged 1 commit into from
Aug 25, 2024

Conversation

azu
Copy link
Collaborator

@azu azu commented Aug 25, 2024

変更点

  • marked@4からmarked@14にアップデート
  • <h1 id=xxx> は付与されなくなったので出力から削除
    • auto linkについては言及してるが、idについては言及してないのでコードのみの変更

fix #1694

cc @SotaYamaguchi

@azu azu linked an issue Aug 25, 2024 that may be closed by this pull request
3 tasks
Comment on lines -1 to 4
<h1 id="サンプルファイル">サンプルファイル</h1>
<h1>サンプルファイル</h1>
<p>これはサンプルです。
<a href="https://jsprimer.net/">https://jsprimer.net/</a></p>
<ul>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GFMではauto linkが有効になってる

@bot-user
Copy link

Deploy Preview for js-primer ready!

Name Link
🔨 Latest commit ac58e40
🔍 Latest deploy log https://app.netlify.com/sites/js-primer/deploys/66caa64af09d170008169237
😎 Deploy Preview https://deploy-preview-1760--js-primer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azu azu marked this pull request as ready for review August 25, 2024 03:36
@azu azu requested a review from lacolaco August 25, 2024 03:36
@azu azu changed the title fix(nodecli): update marked@14 fix(nodecli): update to marked@14 Aug 25, 2024
@azu azu merged commit 9101ff8 into master Aug 25, 2024
13 checks passed
@azu azu deleted the feature/1694 branch August 25, 2024 04:00
@lacolaco
Copy link
Collaborator

ありがとうございます!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markedjsのアップデート
3 participants