Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing JVM arguments and command line arguments to JVM plugins #397

Closed
ascopes opened this issue Sep 21, 2024 · 0 comments · Fixed by #395 or #399
Closed

Support passing JVM arguments and command line arguments to JVM plugins #397

ascopes opened this issue Sep 21, 2024 · 0 comments · Fixed by #395 or #399
Assignees
@ascopes
Labels
new feature A new user-facing feature.
Milestone
v2.6.x

Comments

@ascopes
Copy link
Owner

ascopes commented Sep 21, 2024

I am using our own proto plugin inside this protobuf maven plugin using the configuration jvmMavenPlugin. Is there any way I can pass args into the main method of my custom plugin?

Originally posted by @abrua1 in #391

From analysis, thr Xolstice Maven plugin allowed users to inject JVM arguments and command line arguments when invoking the JVM. This should be relatively simple to support as a new feature.

Things to support:

  • Command line arguments
  • JVM arguments (to allow users to control JVM heap settings, attach remote debuggers, etc).
@ascopes ascopes added the new feature A new user-facing feature. label Sep 21, 2024
@ascopes ascopes added this to the v2.6.x milestone Sep 21, 2024
@ascopes ascopes self-assigned this Sep 21, 2024
@ascopes ascopes linked a pull request Sep 21, 2024 that will close this issue
GH-393: Use tiered level-1 compilation when running JVM subprocesses #395
Merged
ascopes added a commit that referenced this issue Sep 21, 2024
@ascopes
GH-394: Use Java argument files for command line arguments
bf45f0b 
This is far more reliable in cross-platform parsing consistency, and
mostly superceeds the use of Shlex, although we still rely on it
to deal with simple path quoting. We may be able to refactor this out
entirely in the future.

The change also helps support GH-397's implementation which introduces
a higher risk of bugs slipping in through the unreliable batch
specifications for argument parsing.
@ascopes ascopes mentioned this issue Sep 21, 2024
Merged
ascopes added a commit that referenced this issue Sep 22, 2024
@ascopes
GH-397: implement ability to specify JVM arguments to plugins
804d59f
@ascopes ascopes mentioned this issue Sep 22, 2024
Merged
ascopes added a commit that referenced this issue Sep 22, 2024
@ascopes
GH-397: Work around quirk in immutables defaults for unmodifiable col…
db73ba2 
…lections

Seems that immutables will not attempt to reconstruct mutable
variants of Lists from the default values, and Maven raises
no exceptions when this fails. Work-around for now is to use
null defaults.
ascopes added a commit that referenced this issue Sep 22, 2024
@ascopes
GH-397: implement ability to specify JVM arguments to plugins
173a980
ascopes added a commit that referenced this issue Sep 22, 2024
@ascopes
GH-397: Bump version to 3.6.0
ef91257
ascopes added a commit that referenced this issue Sep 22, 2024
@ascopes
Merge pull request #399 from ascopes/feature/GH-397-jvm-arguments
9d452a6 
GH-397: implement ability to specify JVM arguments to plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ascopes ascopes

Labels
new feature A new user-facing feature.
Projects
None yet
Milestone
v2.6.x
1 participant
@ascopes