Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JDK 23 for builds #401

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Use JDK 23 for builds #401

merged 5 commits into from
Sep 23, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Sep 23, 2024

No description provided.

@ascopes ascopes added the general improvements Fixing/updating internal components and code label Sep 23, 2024
@ascopes ascopes self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (b97acb2) to head (3fa1796).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          33       33           
  Lines        1119     1119           
  Branches       74       74           
=======================================
  Hits          982      982           
  Misses        103      103           
  Partials       34       34           
Files with missing lines Coverage Δ
...protobufmavenplugin/mojo/AbstractGenerateMojo.java 100.00% <ø> (ø)

@ascopes
Copy link
Owner Author

ascopes commented Sep 23, 2024

Need to enable -proc:full on JDK 23. Looks like they've backported it to the latest JDK releases of Java 17 and Java 11 but not others so may have to use a custom Maven profile for this.

@ascopes ascopes marked this pull request as ready for review September 23, 2024 19:55
@ascopes ascopes merged commit 2eb9440 into main Sep 23, 2024
12 checks passed
@ascopes ascopes deleted the task/java-23 branch September 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general improvements Fixing/updating internal components and code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant