Tweak UsesSystemProperties.java #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ascopes
commented
Sep 28, 2024
ascopes
commented
- Demote logging to debug level
- Rename inner extension class to be clearer
- Remove self-referential import
- Mark extension as final
- Update JavaDocs
- Unmark field as volatile as it is not synchronized anyway
- Mark annotation as "Inherited"
- Demote logging to debug level - Rename inner extension class to be clearer - Remove self-referential import - Mark extension as final - Update JavaDocs - Unmark field as volatile as it is not synchronized anyway - Mark annotation as "Inherited"
ascopes
added
the
general improvements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 33 33
Lines 1117 1117
Branches 74 74
=======================================
Hits 979 979
Misses 104 104
Partials 34 34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.