Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-26: Add tests for $PATH resolution of protoc #84

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Feb 4, 2024

Added tests for calling protoc from the system PATH.

@ascopes ascopes added the java label Feb 4, 2024
@ascopes ascopes self-assigned this Feb 4, 2024
@ascopes ascopes force-pushed the task/GH-26-test-path-resolution branch from d936b7f to 6c3e1b8 Compare February 4, 2024 10:19
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b74841) 81.62% compared to head (96a7ffa) 86.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   81.62%   86.85%   +5.23%     
==========================================
  Files          21       21              
  Lines         631      631              
  Branches       54       54              
==========================================
+ Hits          515      548      +33     
+ Misses         95       58      -37     
- Partials       21       25       +4     

see 2 files with indirect coverage changes

@ascopes ascopes force-pushed the task/GH-26-test-path-resolution branch from 6c3e1b8 to e83b84c Compare February 4, 2024 10:39
@ascopes ascopes force-pushed the task/GH-26-test-path-resolution branch from e83b84c to 96a7ffa Compare February 4, 2024 10:46
@ascopes ascopes merged commit e18135f into main Feb 4, 2024
11 checks passed
@ascopes ascopes deleted the task/GH-26-test-path-resolution branch February 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant