Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ProtoSourceResolver to use FutureTask API #95

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Feb 17, 2024

No description provided.

@ascopes ascopes added the java label Feb 17, 2024
@ascopes ascopes self-assigned this Feb 17, 2024
@ascopes ascopes force-pushed the task/rewrote-protosourceresolver branch from 530b698 to 4b69b3c Compare February 17, 2024 13:59
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (304620f) 86.84% compared to head (4b69b3c) 87.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   86.84%   87.17%   +0.34%     
==========================================
  Files          21       21              
  Lines         638      639       +1     
  Branches       55       51       -4     
==========================================
+ Hits          554      557       +3     
+ Misses         60       59       -1     
+ Partials       24       23       -1     
Files Coverage Δ
...rotobufmavenplugin/source/ProtoSourceResolver.java 77.97% <72.50%> (+3.83%) ⬆️

@ascopes ascopes merged commit 91e323b into main Feb 17, 2024
11 of 12 checks passed
@ascopes ascopes deleted the task/rewrote-protosourceresolver branch February 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant