Fix label mapper examples #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to have been malformed for quite some time, but it's not clear exactly why the tests were passing anyway. This issue was discovered in the course of updating the asdf package to use ruamel.yaml instead of pyyaml. It appears that ruamel.yaml provides proper support for omap whereas pyyaml did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to have been malformed for quite some time, but it's not clear exactly why the tests were passing anyway. This issue was discovered in the course of updating the asdf package to use
ruamel.yamlinstead ofpyyaml. It appears thatruamel.yamlprovides proper supportfor
omapwhereaspyyamldid not (see yaml/pyyaml#78).This also makes updates related to changes to the schema tester plugin made in asdf-format/asdf#676.